Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DiagnosticSource to CheckNonEventSourcesRunning #106337

Conversation

matouskozak
Copy link
Member

@matouskozak matouskozak commented Aug 13, 2024

The introduction of ActiveSources in System.Net (#103922) started causing failures where Microsoft-Diagnostics-DiagnosticSource runs on iOS tests which wasn't expected. This PR adds Microsoft-Diagnostics-DiagnosticSource to the CheckNoEventSourcesRunning built-in EventSource list so that it's no longer considered as running (suggested at #104881 (comment)).

Should fix #104881

@matouskozak
Copy link
Member Author

/azp run runtime-ioslikesimulator

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh
Copy link
Member

tarekgh commented Aug 13, 2024

CC @davmason

Copy link
Member

@davmason davmason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matouskozak matouskozak marked this pull request as ready for review August 14, 2024 06:56
@matouskozak matouskozak merged commit 6af2d34 into dotnet:main Aug 14, 2024
89 of 91 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Sep 14, 2024
@matouskozak matouskozak deleted the add-DiagnosticSource-to-CheckNonEventSourcesRunning branch October 3, 2024 13:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Apple] Microsoft-Diagnostics-DiagnosticSource EventSource not terminated properly
4 participants